Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: cset-2884 refactor ReportsDataBusiness #4275

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

itsmostafa
Copy link
Collaborator

πŸ—£ Description

πŸ’­ Motivation and context

πŸ§ͺ Testing

βœ… Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

βœ… Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

βœ… Post-merge checklist

  • Create a release.

@itsmostafa itsmostafa self-assigned this Dec 4, 2024
@itsmostafa itsmostafa requested a review from randywoods December 5, 2024 00:54
@itsmostafa itsmostafa marked this pull request as ready for review December 5, 2024 01:12
@randywoods randywoods merged commit 7aa644c into develop Dec 5, 2024
4 checks passed
@randywoods randywoods deleted the feature/cset-2884 branch December 5, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants