Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Python versions support #121

Merged
merged 1 commit into from
Oct 19, 2017
Merged

Conversation

IanLee1521
Copy link
Collaborator

Travis was testing Python 3.6, not included in the setup.py
classifiers list. Meanwhile, 3.4 is in the classifiers, but
not being tested. This brings those two in sync.

Travis was testing Python 3.6, not included in the setup.py
classifiers list. Meanwhile, 3.4 is in the classifiers, but
not being tested. This brings those two in sync.
@konklone
Copy link
Collaborator

konklone commented Oct 2, 2017

I think we can probably drop 3.4 from both, personally. But 👍 from me either way. @h-m-f-t ?

@IanLee1521
Copy link
Collaborator Author

Possibly.

My feeling on this has often been that "as long as I don't have to do anything more / new / extra to "support" an older version, I will. The minute I go to add a feature that wouldn't work in Python3.4 (for instance) is when I would think about dropping it.

Based on the tests though, this works in Python 3.4 with no changes needed, so I vote we keep it. (Also, since I think Python3.4 is/was the default Python3 in a few versions of Linux, e.g. Ubuntu 14.04, etc)

@h-m-f-t h-m-f-t merged commit e4e0093 into cisagov:master Oct 19, 2017
@IanLee1521 IanLee1521 deleted the py-versions branch October 21, 2017 05:04
cisagovbot pushed a commit that referenced this pull request Apr 26, 2023
Lineage pull request for: skeleton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants