Test framework #122
Merged
Test framework #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverages the *.badssl.com sites as the "known" / "expected" behavior
These require more work with `vcrpy` or similar mocking before enabling
This is meant to encompass checks for things like "Supports HTTPS" and "Enforces HTTPS" which have more complicated logic associated with them.
|
Changes Unknown when pulling fd8f851 on IanLee1521:test-framework into ** on dhs-ncats:master**. |
2 similar comments
|
Changes Unknown when pulling fd8f851 on IanLee1521:test-framework into ** on dhs-ncats:master**. |
|
Changes Unknown when pulling fd8f851 on IanLee1521:test-framework into ** on dhs-ncats:master**. |
|
Changes Unknown when pulling c098879 on IanLee1521:test-framework into ** on dhs-ncats:master**. |
|
@IanLee1521 <3 tests <3 |
cisagovbot
pushed a commit
that referenced
this pull request
Jan 7, 2023
Update two configuration files
cisagovbot
pushed a commit
that referenced
this pull request
Jul 12, 2023
Lineage pull request for: skeleton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a test harness for pshtt which enables functional testing, and begins work (skipped for now: master...IanLee1521:test-framework#diff-4b8ef9663ddcb745c9b2af6c8974c69fR32) to allow for integration tests against live badssl.com endpoints.
Instead of live hits to badssl though, it may be preferable to record the HTTP requests/responses and replay those, e.g. using
vcrpy, investigation of which is still on going and will be added in future pull requests.