Switch helper package for the Public Suffix List #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from using the deprecated (and very out-of-date) publicsuffix package to using the currently maintained publicsuffixlist package. The publicsuffixlist package has a compatibility layer specifically for code that is already using the publicsuffix package so changes are minimal.
8 tasks
jsf9k
approved these changes
Jan 23, 2023
6 tasks
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request switches Public Suffix List helper packages from publicsuffix to publicsuffixlist. Any necessary supporting changes are also made.
💭 Motivation and context
The publicsuffix package is deprecated and has not been maintained for years. It finally reached a breaking point during this past weekend's BOD 18-01 scanning run where the server hosting the maintained public suffix list no longer returned the
charsetheader that publicsuffix expects. The publicsuffixlist package is the currently maintained one of the two alternatives mentioned by publicsuffix and it has a compatibility layer for existing code that uses publicsuffix.🔔 See also
🧪 Testing
Automated tests pass. I confirmed that I was able to perform a local scan using this branch.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist