Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include gocritic, gosec and staticcheck versions #65

Merged
merged 11 commits into from
Aug 22, 2023
Merged

Include gocritic, gosec and staticcheck versions #65

merged 11 commits into from
Aug 22, 2023

Conversation

jasonodoom
Copy link
Contributor

@jasonodoom jasonodoom commented Jul 10, 2023 •
edited by jsf9k
Loading

🗣 Description

This PR is to track the versions for GoCritic, GoSec and Staticcheck into this repo so it can be consumed/used in GitHub Actions workflows.

💭 Motivation and context

This change is based on current team practices.

🧪 Testing

Pre-commit verified syntactical accuracy.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

mcdonnnj
mcdonnnj requested changes Jul 11, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@jsf9k
Copy link
Member

jsf9k commented Jul 11, 2023

@jasonodoom - Please note that I added back into the PR description a checkbox that you deleted in what I assume was an accident of haste.

jasonodoom and others added 5 commits July 11, 2023 09:51
@jasonodoom @mcdonnnj
Update README.md
a2e3bba 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jasonodoom @mcdonnnj
Update staticcheck references and naming
d2ce591 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jasonodoom @mcdonnnj
Update statichceck id
08c686b 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jasonodoom @mcdonnnj
Update staticcheck version.
c625d81 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jasonodoom @mcdonnnj
Update go-critic description.
821e794 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jasonodoom
Copy link
Contributor Author

@jasonodoom - Please note that I added back into the PR description a checkbox that you deleted in what I assume was an accident of haste.

@jsf9k It definitely was. 😓 Thank you!

@jasonodoom @mcdonnnj
Update go-critic version
acbb6ea 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jasonodoom jasonodoom requested a review from mcdonnnj July 11, 2023 13:57
jsf9k
jsf9k requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this PR should be merged until this conversation is resolved.

@jsf9k
Copy link
Member

jsf9k commented Jul 11, 2023

I don't think this PR should be merged until this conversation is resolved.

That conversation is now resolved.

@jsf9k jsf9k added documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Jul 11, 2023
dav3r
dav3r approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :goberserk:

@mcdonnnj mcdonnnj mentioned this pull request Jul 11, 2023
Merged
8 tasks
jsf9k added a commit to cisagov/skeleton-generic that referenced this pull request Jul 12, 2023
@jsf9k
Temporarily use a different branch of cisagov/setup-env-github-action
ddbf6f7 
This is being done for testing purposes, and this commit can be
reverted (or removed) once cisagov/setup-env-github-action#65 is
merged.
@jasonodoom
Copy link
Contributor Author

jasonodoom commented Jul 12, 2023 •
edited
Loading

I don't think this PR should be merged until this conversation is resolved.

@jsf9k but doesn't this have to be merged first to pull in the defined package versions? I can actually test in a different branch but the builds from generic will fail if this isn't merged first.

@jsf9k
Copy link
Member

jsf9k commented Jul 12, 2023

I don't think this PR should be merged until this conversation is resolved.

@jsf9k but doesn't this have to be merged first to pull in the defined package versions? I can actually test in a different branch but the builds from generic will fail if this isn't merged first.

@jasonodoom - Please see here. I temporarily modified the GitHub Actions workflow in cisagov/skeleton-generic to use this branch to get around this very issue.

mcdonnnj
mcdonnnj reviewed Jul 13, 2023
View reviewed changes
action.yml Outdated Show resolved Hide resolved
jsf9k
jsf9k requested changes Jul 13, 2023
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@jasonodoom jasonodoom force-pushed the add-go-actions-for-go-skeleton branch 3 times, most recently from 265128b to acbb6ea Compare July 17, 2023 19:12
@jasonodoom jasonodoom requested a review from mcdonnnj July 17, 2023 20:21
mcdonnnj
mcdonnnj approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one adjustment but otherwise LGTM ✔

README.md Outdated Show resolved Hide resolved
@jasonodoom @mcdonnnj
Fix stylization and description for gosec
8de4548 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jasonodoom jasonodoom requested a review from mcdonnnj August 16, 2023 18:25
mcdonnnj
mcdonnnj approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

@jsf9k jsf9k merged commit e3c058a into develop Aug 22, 2023
@jsf9k jsf9k deleted the add-go-actions-for-go-skeleton branch August 22, 2023 14:14
jsf9k added a commit to cisagov/skeleton-generic that referenced this pull request Aug 22, 2023
@jsf9k
Revert "Temporarily use a different branch of cisagov/setup-env-githu…
98d3d3f 
…b-action"

This reverts commit ddbf6f7.

This can be done now that cisagov/setup-env-github-action#65 has been
merged.
jsf9k added a commit to cisagov/ansible-role-clamav that referenced this pull request Dec 19, 2023
@jsf9k
Temporarily use a different branch of cisagov/setup-env-github-action
82b34e3 
This is being done for testing purposes, and this commit can be
reverted (or removed) once cisagov/setup-env-github-action#65 is
merged.
jsf9k added a commit to cisagov/ansible-role-clamav that referenced this pull request Dec 19, 2023
@jsf9k
Revert "Temporarily use a different branch of cisagov/setup-env-githu…
dfb9efc 
…b-action"

This reverts commit ddbf6f7.

This can be done now that cisagov/setup-env-github-action#65 has been
merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jasonodoom jasonodoom

Labels
documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasonodoom @jsf9k @dav3r @mcdonnnj