fix foreign test for i3nt #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want to update mats/ftype.h too? |
|
That seems like a good idea. It turns out that |
For some build environments, `_WIN32` is needed in "foreign3.c" (as in other "foreign*.c" files) instead of `WIN32` without the leading underscore. Also, simplify "mats/build.zuo" by using `_WIN32` in "ftype.h".
mflatt
force-pushed
the
foreign-test-win32
branch
from
4e972ce
to
e363465
Compare
|
There are many other files in Chez Scheme that use WIN32 without the underscore: |
|
Would it make more sense to convert the few _WIN32 cases to use WIN32, and then make sure WIN32 is defined in all the build environments? |
|
Microsoft documents _WIN32, so maybe it would make more sense to convert all the WIN32 instances to _WIN32? https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170 |
|
The build issues for files that make up the kernel are a little different than for files for tests (e.g., tests don't need to cross-compile, and they don't need the various linking modes that the kernel might be compiled for on Windows). I'm inclined to leave things alone in the "c" directory, because C-level build changes so often have surprises. That said, I do think it would make sense switch to |
|
Let's fix the ones in mats to use _WIN32 and leave WIN32 for the rest. That shouldn't rock the boat. The ones in csug work because the example compiler command uses -DWIN32. |
burgerrg
approved these changes
Aug 6, 2024
|
Sounds great to me - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some build environments,
_WIN32is needed (as in other "foreign*.c" files) instead ofWIN32without the leading underscore.