Cleaning up cmake and enabled more warnings. #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Cleaning up cmake and enabled more warnings. (CMake structure from https://github.com/franneck94/CppProjectTemplate) * dummy commit to trigger workflow * revert "dummy commit to trigger workflow" * Adopt to sligtly modified CMake default options * One more try * Ditch tools * Add warnings to test target(s) * Turning off clang warnings. Ignoring string literal warnings in tests output. * Revert "Turning off clang warnings." This reverts commit 82b7812. * Turning off warnings for clang * Turning off MSVC warnings. * Removed unused options and turn of sanitizers by default. * Turn on C extensions. Otherwise GXX wont find networking and singnaling structs. * Opps. Deleted the wrong file a few commits ago. Fixing now. * Cleaning up --------- Co-authored-by: Pascal Bühler <pabuhler@cisco.com>
|
LGTM, if only the conflict was fixed :) |
And removed newline.
|
Sorry about that. Conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning! There are still lots of compiler warnings turned off.
A good code cleanup is needed to turn those on (cmake/Warnings.cmake)
-Wformat=2 # warn on security issues around functions that format output
-Wcast-align # warn for potential performance problem casts
-Wconversion # warn on type conversions that may lose data
-Wsign-conversion # warn on sign conversions