Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory overflow and capacity regression. #727

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+10 −7
Open

Fix memory overflow and capacity regression. #727

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
def1201
Fix for Memory Safety Issue
DrHazemAli Nov 9, 2024
ab6d063
Update srtp.c
DrHazemAli Nov 10, 2024
9bb05f1
Update srtp.c
DrHazemAli Nov 13, 2024
e16da02
clang-formatted srtp.c
DrHazemAli Nov 13, 2024
e1d82d8
Revert "clang-formatted srtp.c"
pabuhler Nov 14, 2024
63f774d
update formatting
pabuhler Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions srtp/srtp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4899,8 +4899,7 @@ srtp_err_status_t srtp_stream_list_insert(srtp_stream_list_t list,
size_t new_capacity = list->capacity * 2;

// check for capacity overflow.
if ((sizeof(list_entry) * new_capacity) <=
(sizeof(list_entry) * list->capacity)) {
if (new_capacity < list->capacity || new_capacity > SIZE_MAX / sizeof(list_entry)) {
return srtp_err_status_alloc_fail;
}

Expand Down
Loading