Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tooltip to EasyPill delete action #370

Merged
merged 3 commits into from
Jun 29, 2022
Merged

added tooltip to EasyPill delete action #370

merged 3 commits into from
Jun 29, 2022

Conversation

ManoloAlvarezForo
Copy link
Contributor

  • Added tooltip in addon EasyPill
  • Added tooltip direction prop
  • Unit test
  • updated story for EasyPill

dkordik
dkordik reviewed Jun 28, 2022
View reviewed changes
src/components/EasyPill/EasyPill.module.css Outdated Show resolved Hide resolved
src/components/EasyPill/EasyPill.module.css Outdated Show resolved Hide resolved
src/components/EasyPill/EasyPill.tsx Outdated Show resolved Hide resolved
@ManoloAlvarezForo
Copy link
Contributor Author

Thanks @alexanderAlatorreGoveaCision @ftrinidad-cision @dkordik for your code review, I resolved all observations

@dkordik
Copy link
Collaborator

dkordik commented Jun 29, 2022

sorry, I shoulda mentioned this earlier- can you post screenshots for this kinda stuff?

@ManoloAlvarezForo
Copy link
Contributor Author

Here the image with the tooltip in EasyPill

EasyPill with tooltip in delete action

@ManoloAlvarezForo ManoloAlvarezForo merged commit ab0bf07 into master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkordik dkordik dkordik approved these changes

@alexanderAlatorreGoveaCision alexanderAlatorreGoveaCision alexanderAlatorreGoveaCision approved these changes

@ftrinidad-cision ftrinidad-cision ftrinidad-cision approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ManoloAlvarezForo @dkordik @alexanderAlatorreGoveaCision @ftrinidad-cision