nit: rename fn 'join_all' & make it private

citadel-tech · Dec 12, 2024 · 1ca49c6 · 1ca49c6
1 parent e75d200
commit 1ca49c6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/maker/api.rs b/src/maker/api.rs
@@ -103,7 +103,7 @@ impl Default for ThreadPool {
 
 impl Drop for ThreadPool {
     fn drop(&mut self) {
-        if let Err(e) = self.join_all() {
+        if let Err(e) = self.join_all_threads() {
             log::error!("Error joining threads in via drop: {:?}", e);
         }
     }
@@ -121,7 +121,7 @@ impl ThreadPool {
         threads.push(handle);
     }
 
-    pub fn join_all(&self) -> Result<(), MakerError> {
+    fn join_all_threads(&self) -> Result<(), MakerError> {
         let mut threads = self
             .threads
             .lock()