Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Maybe add bitcoind binary in .github? #92

Closed
rajarshimaitra opened this issue Feb 10, 2024 · 0 comments · Fixed by #102
Closed

test: Maybe add bitcoind binary in .github? #92

rajarshimaitra opened this issue Feb 10, 2024 · 0 comments · Fixed by #102
Assignees
Labels
tests Testing related improvements
Milestone

Comments

@rajarshimaitra
Copy link

We require the bitcoind binary for every build. This is due to the usage to bitcoind crate for our integration tests.

Currently for every github action build run, bitcoind is downloaded. As defined here https://github.com/utxo-teleport/teleport-transactions/blob/dda5c2d9c80cec6ccaec13b5d5038fc10c3a6d53/src/test_framework.rs#L89

This often causes unmitigable test failure in our CI when the set URL to download bitcoind is unresponsive for any reason. This also increases our CI build time, as downloading the binary takes some time.

It is possible to provide a path to bitcoind in the above command instead of from_downloaded. We can keep the bitcoind in our .github folder as pass that path in the BitcoinD build call.

ps: This will increase our repo sizew. We will be literally shipping bitcoind with our repo. This won't increase the final binary size of our code though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Testing related improvements
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants