Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bitcoind binary on path bin/bitcoind for CI caching #102

Merged

Conversation

Shourya742
Copy link

@Shourya742 Shourya742 commented Mar 3, 2024

closes: #92
Added bitcoind binary on path bin/bitcoind. This is done to eliminate bitcoind download failures which happen sometimes running the test.

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.62%. Comparing base (db0a89f) to head (099827b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   73.54%   73.62%   +0.08%     
==========================================
  Files          28       28              
  Lines        6115     6115              
==========================================
+ Hits         4497     4502       +5     
+ Misses       1618     1613       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shourya742 Shourya742 self-assigned this Mar 3, 2024
Copy link

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@rajarshimaitra rajarshimaitra merged commit b00c1fc into citadel-tech:master Mar 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Maybe add bitcoind binary in .github?
2 participants