Improvements in maker app #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claddyy
force-pushed
the
improvements
branch
from
abd7019 to
9fa4951
Compare
claddyy
force-pushed
the
improvements
branch
from
9fa4951 to
e1c0526
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
==========================================
- Coverage 78.18% 74.34% -3.85%
==========================================
Files 32 32
Lines 4859 4073 -786
==========================================
- Hits 3799 3028 -771
+ Misses 1060 1045 -15 ☔ View full report in Codecov by Sentry. |
mojoX911
requested changes
Dec 17, 2024
KnowWhoami
requested changes
Dec 17, 2024
Suggestions by @mojoX911 and @KnowWhoami addressed in 482e86d |
claddyy
force-pushed
the
improvements
branch
from
482e86d to
3235739
Compare
KnowWhoami
reviewed
Dec 18, 2024
claddyy
force-pushed
the
improvements
branch
2 times, most recently
from
8d47bd7 to
5f4b6f7
Compare
claddyy
force-pushed
the
improvements
branch
from
5f4b6f7 to
09718c6
Compare
mojoX911
requested changes
Dec 18, 2024
mojoX911
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the improvements mentioned in #316 (review)
It names the recovery thread using the
nameAPI.This adds a couple of logs in fn
join_all_threads, which would be helpful while debugging.