Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redeemscript.instructions() now reads hashvalue #72

Merged
merged 2 commits into from
Dec 21, 2023
Merged

redeemscript.instructions() now reads hashvalue #72

merged 2 commits into from
Dec 21, 2023

Conversation

wthrajat
Copy link

@wthrajat wthrajat commented Dec 7, 2023

Implements a better way to read hashvalue from contract in src/protocol/contract.rs as instructed here:

// put all these magic numbers in a const or something
// a better way is to use redeemscript.instructions() like read_locktime_from_contract()

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bbb268d) 69.19% compared to head (7573e73) 69.18%.

Files Patch % Lines
src/protocol/contract.rs 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   69.19%   69.18%   -0.01%     
==========================================
  Files          28       28              
  Lines        5778     5780       +2     
==========================================
+ Hits         3998     3999       +1     
- Misses       1780     1781       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wthrajat
Copy link
Author

wthrajat commented Dec 7, 2023

TODO: fix clippy lint

@wthrajat wthrajat marked this pull request as draft December 8, 2023 05:51
@wthrajat wthrajat marked this pull request as ready for review December 10, 2023 16:51
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
@wthrajat wthrajat changed the title fix: redeemscript.instructions() used for better redeemscript.instructions() now reads hashvalue Dec 21, 2023
Copy link

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7573e73

@rajarshimaitra rajarshimaitra merged commit 490485d into citadel-tech:master Dec 21, 2023
8 checks passed
@wthrajat wthrajat self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants