-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test:
unit tests for wallet/swapcoin.rs
#96
Conversation
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 71.56% 73.58% +2.02%
==========================================
Files 28 28
Lines 5911 6115 +204
==========================================
+ Hits 4230 4500 +270
+ Misses 1681 1615 -66 ☔ View full report in Codecov by Sentry. |
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK. Please rebase after merge of #100 to pickup the clippy fixes.
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Rebased after the merge of #100! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 451353d
Aims to fix #81.
Added unit tests for various methods like:
Keeping our
codecov
in mind, various fail/error cases have also been covered to get the coverage higher. Also some tests are implemented for all three structs likeIncomingSwapcoin
,OutgoingSwapcoin
,WatchonlySwapcoin
to get more codecov coverage.PS: After merging, we will go from
65%
to85%
in thisswapcoin.rs
. Also these tests indirectly increased the coverage in several other files as well. We'll analyze the overall codecov once this is merged.