Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Unit test for wallet/direct_send.rs #99

Closed
wants to merge 8 commits into from
Closed

tests: Unit test for wallet/direct_send.rs #99

wants to merge 8 commits into from

Conversation

wthrajat
Copy link

Aims to fix #83, currently WIP.
Refactor the APIs for slight logic improvements and better error handling.
Also the previous tests are extended for various edge cases.

fn create_direct_send()

^ is also implemented for the unit test - after which the whole module is covered keeping our codecov in mind.

Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
@wthrajat wthrajat self-assigned this Feb 21, 2024
@wthrajat wthrajat added the tests Testing related improvements label Feb 21, 2024
@wthrajat wthrajat added this to the v0.1.0 milestone Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 51.08696% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 73.05%. Comparing base (e794ff0) to head (a1d1e3e).
Report is 1 commits behind head on master.

❗ Current head a1d1e3e differs from pull request most recent head 808f62e. Consider uploading reports for the commit 808f62e to get more accurate results

Files Patch % Lines
src/wallet/direct_send.rs 51.64% 44 Missing ⚠️
src/wallet/api.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   78.64%   73.05%   -5.59%     
==========================================
  Files          25       28       +3     
  Lines        6045     6194     +149     
==========================================
- Hits         4754     4525     -229     
- Misses       1291     1669     +378     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
@rajarshimaitra
Copy link

Please rebase after #100 merge to pick up the clippies.

@rajarshimaitra
Copy link

Closing this as the internals of direct send api changed and a test to spend swap coins are added. In #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Testing related improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: Unit test for wallet/direct_send.rs
2 participants