Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine estimateQuota's error info #886

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

leeyr338
Copy link
Contributor

@leeyr338 leeyr338 commented Nov 13, 2019

Refine estimateQuota's error info.
The reason for failed in estimateQuota, not just "Requires quota higher than upper limit", but also some internal errors, like Reverted or something else.

A little more detail about the error, see:
https://github.com/cryptape/citahub-docs/pull/391/files

@jerry-yu jerry-yu merged commit 05f7aaf into citahub:develop Nov 14, 2019
rink1969 added a commit that referenced this pull request Feb 13, 2020
* Fix the link of release guide. [skip ci]

* Update cita-bft: add panic info. [skip travis]

* Use cita-database from crates.

* Bump blake2 to `0.8.1` to fix security check.

* Hard code release version

* Add setBlockInterval interface

* Add test about block interval

* Update submodule[skip audit]

* Add upgrade

* Use utils

* Fix operation typo[skip travis]

* refact executive

* Do not use a magic number.

* Delete unused comments

* Separate bin_dir and work_dir

* CITA Release flow

Add CITA Release flow to review

* Add docker diretory for build release images

* Update and rename. [skip ci]

* Fix audit[skip travis]

* [skip audit]fix for shell check

* Fix some sub-commands error

* Fix error info when file not exit

* Bug fix for handling quota used error when Revert. (#870)

* Fix travis (#877)

* fix for dup tx hash in block

* use new cita-vm

* [skip audit] Add JSON-RPC interface: estimate_quota. (#882)

* Update "flow" to "Flow"

* for[skip ci.[skip ci]

* [skip audit] Bug fix: Error estimate for the first calling contract. (#883)

* [skip audit] Bug fix: executor block in estimate quota larger than BQL

* [skip audit]add black list judge

* [skip audit] refine estimateQuota's error info (#886)

* Fix update admin (#885)

* [skip audit]fix update admint solc
use new genensis

* [skip audit]fix test permission

* fix add admin permission error

* fix auth cancel error

* [skip audit] fix permission.js

* [skip audit]fix space

* [skip audit]fix bug address in black list can't dismiss

* update submodule url[skip ci] (#891)

* Remove circle resource restrictions (#890)

* Remove circle resource restrictions[skip audit]

* Use only one jobs[skip audit]

* update info (#892)

* [skip audit]update info; upgrade rust to 1.39

* update ci config

* [skip audit]update ci config

* [skip audit]limit to 1 job

* [skip audit]update info

* [skip audit]update sdk version

* [skip audit]update cita-common; remove unused bin; update cita-run docker image

* [skip audit][skip ci]docker reap zombie processes

* Reveal solc command stderr output [skip audit] (#895)

* [skip ci]fix release.sh; Don't use fixed container name; add crates mirror when necessary

* [skip ci]fix container name

* [skip audit]fix ci (#899)

* Remove set block interval interface (#900)

* update interaction submodule

* Revert "Merge pull request #857 from ouwenkg/upgrade-scripts"

This reverts commit 29897d2, reversing
changes made to 24f1649.

* Revert "Merge pull request #855 from
ouwenkg/interface-block-interval"[skip audit]

This reverts commit 24f1649, reversing
changes made to 9d209c2.

* [skip ci]set cita_build container as bridge model (#901)

* [skip ci]fix copyright info (#903)

* [skip audit]fix volume path when cita_run (#905)

* [skip audit]fix bound bug about filter (#904)

* [skip ci]Update README

* [skip audit]fix run-in-docker judge error. (#907)

* Fix gas calculation error.[skip audit] (#908)

* Refine quota-estimate.[skip audit] (#909)

* Bump to 20.2.0 [skip audit].

Co-authored-by: ka <kaikaifeng1024@gmail.com>
Co-authored-by: AsceticBear <wpf15701504487@gmail.com>
Co-authored-by: nanmuxiusi <42529063+nanmuxiusi@users.noreply.github.com>
Co-authored-by: yubo <anhuitianyu@163.com>
Co-authored-by: zhiwei <rink1969@gmail.com>
Co-authored-by: bsdelf <shen.elf@gmail.com>
rink1969 added a commit that referenced this pull request Feb 15, 2020
* Fix the link of release guide. [skip ci]

* Update cita-bft: add panic info. [skip travis]

* Use cita-database from crates.

* Bump blake2 to `0.8.1` to fix security check.

* Hard code release version

* Add setBlockInterval interface

* Add test about block interval

* Update submodule[skip audit]

* Add upgrade

* Use utils

* Fix operation typo[skip travis]

* refact executive

* Do not use a magic number.

* Delete unused comments

* Separate bin_dir and work_dir

* CITA Release flow

Add CITA Release flow to review

* Add docker diretory for build release images

* Update and rename. [skip ci]

* Fix audit[skip travis]

* [skip audit]fix for shell check

* Fix some sub-commands error

* Fix error info when file not exit

* Bug fix for handling quota used error when Revert. (#870)

* Fix travis (#877)

* fix for dup tx hash in block

* use new cita-vm

* [skip audit] Add JSON-RPC interface: estimate_quota. (#882)

* Update "flow" to "Flow"

* for[skip ci.[skip ci]

* [skip audit] Bug fix: Error estimate for the first calling contract. (#883)

* [skip audit] Bug fix: executor block in estimate quota larger than BQL

* [skip audit]add black list judge

* [skip audit] refine estimateQuota's error info (#886)

* Fix update admin (#885)

* [skip audit]fix update admint solc
use new genensis

* [skip audit]fix test permission

* fix add admin permission error

* fix auth cancel error

* [skip audit] fix permission.js

* [skip audit]fix space

* [skip audit]fix bug address in black list can't dismiss

* update submodule url[skip ci] (#891)

* Remove circle resource restrictions (#890)

* Remove circle resource restrictions[skip audit]

* Use only one jobs[skip audit]

* update info (#892)

* [skip audit]update info; upgrade rust to 1.39

* update ci config

* [skip audit]update ci config

* [skip audit]limit to 1 job

* [skip audit]update info

* [skip audit]update sdk version

* [skip audit]update cita-common; remove unused bin; update cita-run docker image

* [skip audit][skip ci]docker reap zombie processes

* Reveal solc command stderr output [skip audit] (#895)

* [skip ci]fix release.sh; Don't use fixed container name; add crates mirror when necessary

* [skip ci]fix container name

* [skip audit]fix ci (#899)

* Remove set block interval interface (#900)

* update interaction submodule

* Revert "Merge pull request #857 from ouwenkg/upgrade-scripts"

This reverts commit 29897d2, reversing
changes made to 24f1649.

* Revert "Merge pull request #855 from
ouwenkg/interface-block-interval"[skip audit]

This reverts commit 24f1649, reversing
changes made to 9d209c2.

* [skip ci]set cita_build container as bridge model (#901)

* [skip ci]fix copyright info (#903)

* [skip audit]fix volume path when cita_run (#905)

* [skip audit]fix bound bug about filter (#904)

* [skip ci]Update README

* [skip audit]fix run-in-docker judge error. (#907)

* Fix gas calculation error.[skip audit] (#908)

* Refine quota-estimate.[skip audit] (#909)

* Bump to 20.2.0 [skip audit].

Co-authored-by: ka <kaikaifeng1024@gmail.com>
Co-authored-by: AsceticBear <wpf15701504487@gmail.com>
Co-authored-by: nanmuxiusi <42529063+nanmuxiusi@users.noreply.github.com>
Co-authored-by: yubo <anhuitianyu@163.com>
Co-authored-by: zhiwei <rink1969@gmail.com>
Co-authored-by: bsdelf <shen.elf@gmail.com>

Co-authored-by: yubo <anhuitianyu@163.com>
Co-authored-by: ka <kaikaifeng1024@gmail.com>
Co-authored-by: AsceticBear <wpf15701504487@gmail.com>
Co-authored-by: nanmuxiusi <42529063+nanmuxiusi@users.noreply.github.com>
Co-authored-by: zhiwei <rink1969@gmail.com>
Co-authored-by: bsdelf <shen.elf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants