Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Mary Ann Liebert dependent styles #127

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

POBrien333
Copy link
Contributor

in addition to citation-style-language/styles#5957

This is in communication with the publisher and a list was provided to me.

in addition to citation-style-language/styles#5957

This is in communication with the publisher and a list was provided to me.
@POBrien333 POBrien333 changed the title Create _template.csl Create Mary Ann Liebert dependent styles Mar 10, 2022
@POBrien333
Copy link
Contributor Author

Hi @adam3smith
I'm aware you're very busy these days.
Would you be able to look at this PR though in the coming days as I'd like to close this project with Heather. Thank you :)

@bwiernik bwiernik merged commit b9bb119 into citation-style-language:master Apr 4, 2022
@bwiernik
Copy link
Member

bwiernik commented Apr 4, 2022

Lgtm. Thanks!

@POBrien333
Copy link
Contributor Author

Ahh, you're a star. Thanks, Brenton! :)

@POBrien333
Copy link
Contributor Author

It looks like the styles are not appearing on the repository. Who do we need to ask to get that looked into?

@bwiernik
Copy link
Member

bwiernik commented Apr 6, 2022

@retorquere Anything amiss with the actions?

@POBrien333
Copy link
Contributor Author

Hi @retorquere
Sorry for following up on this so soon again, but were you able to look into this issue? Thank you.

@retorquere
Copy link
Contributor

Sorry, this had entirely slipped my attention, I'll look into it this afternoon.

@retorquere
Copy link
Contributor

The journals repo don't have any kind of merge logic, only the styles and locales repos do. Should the journals repo behave like locales?

This might require changes to Sheldon. At some point we're going to have to overhaul Sheldon. There's a lot of cruft, and I'm just not really current on ruby.

@adam3smith
Copy link
Member

I don't think we want to automate this: good to have a human eye on this before merging -- someone actually has to run the sync script locally and the push the changes. I'm afraid that won't be me until later this week

@retorquere
Copy link
Contributor

So nothing to do for me here?

@adam3smith
Copy link
Member

No, sorry. Thanks for checking and sorry for the false alarm.

@POBrien333
Copy link
Contributor Author

Ahh. Great. Thanks for looking into this.
I'll wait till you let me know when you've ran the script then. thx

adam3smith added a commit to citation-style-language/styles that referenced this pull request Apr 17, 2022
adam3smith added a commit to citation-style-language/styles that referenced this pull request Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants