Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double space before "in" ("dans") in lluelles.csl and lluelles-lexisnexis.csl #1300

Merged
merged 2 commits into from
Jan 17, 2015

Conversation

f-mb
Copy link
Contributor

@f-mb f-mb commented Dec 28, 2014

No description provided.

@zuphilip
Copy link
Member

Side remark: I search for this pattern in the repository locally and there seems to be much more such occurencies among the styles:

Search "<[^/>]*suffix=" "[^/>]*/?>\r\n\s*<[^/>]*prefix=" "[^/>]*/?>" (169 hits in 149 files)

Is this always an error or code this also be somehow meaningful? If some variables are empty or not... For example in vancouver-superscript-only-year:

        <if type="bill book graphic legal_case legislation motion_picture report song" match="any">
          <text macro="edition" prefix=" " suffix=" "/>
          <text macro="publisher" prefix=" "/>
        </if>

My guess is that it is copied from there as a template in several other styles as well...

@adam3smith
Copy link
Member

Adjacent spaces are stripped out by citeproc-js, so they mostly don't cause a lot of problems, but they're indeed always errors in the style and should be avoided (that's to @zuphilip 's point, I'll review and merge this PR later)

adam3smith added a commit that referenced this pull request Jan 17, 2015
Fix double space before "in" ("dans") in lluelles.csl and lluelles-lexisnexis.csl
@adam3smith adam3smith merged commit a732bbf into citation-style-language:master Jan 17, 2015
@adam3smith
Copy link
Member

thanks! (on a side-note: simple pull requests should never take us more than a week to review. Please feel free to send a reminder if we take longer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants