Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra space between citation number and author in pnas.csl #1346

Merged

Conversation

simonster
Copy link
Contributor

No description provided.

adam3smith added a commit that referenced this pull request Jan 21, 2015
Fix extra space between citation number and author in pnas.csl
@adam3smith adam3smith merged commit a4a74d6 into citation-style-language:master Jan 21, 2015
@adam3smith
Copy link
Member

thanks!

@adam3smith
Copy link
Member

@rmzelle @zuphilip -- we may have more of these and they mess with the left-alignment of the citations that have more than 1 line. We should take a closer look.

@zuphilip
Copy link
Member

Okay, I searched for the same pattern

<macro name="author">\s*\r\n\s*<names variable="author"[^>]*prefix=" "

and corrected the resulting other case. Do you think there are still more such cases? If yes, any ideas how to search for them in an easy way?

@adam3smith
Copy link
Member

I think the other scenario would be if the prefix is set on the author macro itself.
pcregrep -Ml '<text variable=\"citation-number\"[^\/]*\/>\n\s*<text macro="author"[^\/]*prefix' *.csl |xargs grep -l 'second-field-align'

gives me this list, which merits a closer look. Feel free to have a go at it, I'm currently mainly trying to wrangle the massive Wiley submission in shape.

acta-anaesthesiologica-taiwanica.csl
advanced-engineering-materials.csl
advanced-materials.csl
advances-in-complex-systems.csl
african-journal-of-emergency-medicine.csl
alexandria-journal-of-medicine.csl
american-physics-society.csl
american-society-of-mechanical-engineers.csl
angewandte-chemie.csl
archives-of-oral-biology.csl
australasian-emergency-nursing-journal.csl
biochimica-et-biophysica-acta.csl
biology-of-reproduction.csl
biomed-research-international.csl
chinese-journal-of-aeronautics.csl
drug-testing-and-analysis.csl
elsevier-vancouver.csl
elsevier-without-titles.csl
elsevier-with-titles-alphabetical.csl
elsevier-with-titles.csl
engineering-in-life-sciences.csl
flavour-and-fragrance-journal.csl
free-radical-research.csl
human-pathology.csl
international-journal-of-gynecology-and-obstetrics.csl
international-journal-of-osteopathic-medicine.csl
journal-francais-dophtalmologie.csl
journal-of-adolescent-health.csl
journal-of-basic-microbiology.csl
journal-of-cellular-and-molecular-medicine.csl
journal-of-integrated-omics.csl
journal-of-separation-science.csl
metallurgical-and-materials-transactions.csl
new-solutions.csl
proteomics.csl
small.csl
transactions-of-the-materials-research-society-of-japan.csl

@rmzelle
Copy link
Member

rmzelle commented Jan 21, 2015

@adam3smith, there is Wiley data?

@simonster, does this mean that you're going to submit your monkey business to PNAS? If so, good luck!

@adam3smith
Copy link
Member

no, sorry. Taylor and Francis. Both blue logos...

@rmzelle
Copy link
Member

rmzelle commented Jan 23, 2015

🐒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants