Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete adjacent space in remaining cases - Part 3 #1357

Merged
merged 2 commits into from
Jan 24, 2015

Conversation

zuphilip
Copy link
Member

( Reference to #1301 )

@zuphilip zuphilip changed the title Delete adjacent space in remaining cases - Part 2 Delete adjacent space in remaining cases - Part 3 Jan 24, 2015
<text macro="page"/>
<text macro="isbn"/>
<text macro="url"/>
<text macro="archive" prefix=" (" suffix=")"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an extra space, too, right? remove.

@adam3smith
Copy link
Member

OK, sorry that most of these notes are actually fixes to things that were wrong before you did this, but I figured while I was reviewing this I might as well catch obvious errors. Let me know if that got too much, I can take some of them.

@zuphilip
Copy link
Member Author

I updated the commit. This should contain all your comments and I added another style: theory-culture-and-society.csl , for which I had first do look at the documentation. I appreciate the possibility to improve on some styles and I think such search pattern can lead us to the more problematic structured implementations. It is worth to spend some time to improve on them. So, no problem.

@adam3smith
Copy link
Member

man, those new Travis builds are fast @rmzelle @inukshuk --thanks again for this.
Looks great now, thanks.

adam3smith added a commit that referenced this pull request Jan 24, 2015
Delete adjacent space in remaining cases - Part 3
@adam3smith adam3smith merged commit fbd74d3 into citation-style-language:master Jan 24, 2015
@zuphilip zuphilip deleted the adjacent-spaces-6 branch February 6, 2015 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants