Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(clrcore): add missing flags and types #2740

Merged
merged 1 commit into from
Oct 21, 2024
Merged

tweak(clrcore): add missing flags and types #2740

merged 1 commit into from
Oct 21, 2024

Conversation

DaniGP17
Copy link
Contributor

@DaniGP17 DaniGP17 commented Aug 21, 2024 •
edited
Loading

Goal of this PR

Add some missing flags and types of animation, blip, ped helmets, rope types, etc

How is this PR achieving the goal

Adding the missing flags and types

This PR applies to the following area(s)

FiveM, ScRT: C#

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added ScRT: C# Issues/PRs related to either C# scripting runtimes invalid Requires changes before it's considered valid and can be (re)triaged labels Aug 21, 2024
@prikolium-cfx
Copy link
Contributor

Can you please squash your commits into 1, and then we can accept this.

@DaniGP17
Copy link
Contributor Author

DaniGP17 commented Oct 4, 2024

Can you please squash your commits into 1, and then we can accept this.

Done

@prikolium-cfx prikolium-cfx added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Oct 7, 2024
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Oct 14, 2024
@prikolium-cfx prikolium-cfx merged commit 78c1a77 into citizenfx:master Oct 21, 2024
7 of 15 checks passed
AvarianKnight added a commit to AvarianKnight/fivem that referenced this pull request Oct 22, 2024
@AvarianKnight
fix(mono): fix breakage accidentally introduced in citizenfx#2740
db7e8ae
AvarianKnight added a commit to AvarianKnight/fivem that referenced this pull request Oct 22, 2024
@AvarianKnight
fix(mono): fix breakage accidentally introduced in citizenfx#2740
06625a6
AvarianKnight added a commit to AvarianKnight/fivem that referenced this pull request Oct 22, 2024
@AvarianKnight
fix(mono): fix breakage accidentally introduced in citizenfx#2740
48405f1
prikolium-cfx added a commit that referenced this pull request Oct 22, 2024
@prikolium-cfx
Merge Fix breakage accidentally introduced in #2740 (pr-2875)
905db00 
48405f1 - fix(mono): fix breakage accidentally introduced in #2740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged ready-to-merge This PR is enqueued for merging ScRT: C# Issues/PRs related to either C# scripting runtimes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniGP17 @prikolium-cfx