Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(txd): bump txd pool size #2776

Closed
wants to merge 1 commit into from
Closed

Conversation

SKITTLE6969
Copy link

@SKITTLE6969 SKITTLE6969 commented Sep 6, 2024

The primary purpose of this commit is to prevent crashes in the two most recent DLCs caused by addon TXDs. After version 2802, the limits were not updated. As a result, many servers are unable to upgrade to the latest DLCs due to TXD limitations. This bump will extend support up to version 2944 with a reasonable set of TXDs. However, further increases will be necessary if we plan to support versions 3095 and 3258.

solves #2724

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Sep 6, 2024
@ook3D
Copy link
Contributor

ook3D commented Sep 7, 2024

Any reason why this is being done? You didn't really explain why, what exactly is this fixing?

@Legacy-TacticalGamingInteractive

Any reason why this is being done? You didn't really explain why, what exactly is this fixing?

He mentioned "solves the txd pool size crashes with atest DLC"

@ook3D
Copy link
Contributor

ook3D commented Sep 7, 2024

Any reason why this is being done? You didn't really explain why, what exactly is this fixing?

He mentioned "solves the txd pool size crashes with atest DLC"

Where did he mention this? I can't seem to see it

@SKITTLE6969
Copy link
Author

Any reason why this is being done? You didn't really explain why, what exactly is this fixing?

updated in intial post

@SKITTLE6969
Copy link
Author

solves #2724

@jellyton255
Copy link

You need to fix the actual commit title, not just the PR title, if you want this PR to successfully validate.

@SKITTLE6969 SKITTLE6969 closed this by deleting the head repository Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants