Fix SystemStackError in schema_dumper.rb in combination with strong_migrations #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igrations When using https://github.com/ankane/strong_migrations gem, it also overrides the SchemaDumper. Reference: https://github.com/Laykou/strong_migrations/blob/master/lib/strong_migrations/schema_dumper.rb strong_migrations in combination with this gem created following issue: ``` SystemStackError: stack level too deep (SystemStackError) .../gems/strong_migrations-1.8.0/lib/strong_migrations/schema_dumper.rb:6:in `new' .../gems/strong_migrations-1.8.0/lib/strong_migrations/schema_dumper.rb:6:in `initialize' .../gems/activerecord-multi-tenant-2.4.0/lib/activerecord-multi-tenant/migrations.rb:93:in `initialize' .../gems/strong_migrations-1.8.0/lib/strong_migrations/schema_dumper.rb:6:in `initialize' .../gems/activerecord-multi-tenant-2.4.0/lib/activerecord-multi-tenant/migrations.rb:93:in `initialize' .../gems/strong_migrations-1.8.0/lib/strong_migrations/schema_dumper.rb:6:in `initialize' ``` `Module#prepend` is recommended approach to be used here instead of monkey patching as advised here ankane/strong_migrations#270 (comment)
|
@gokhangulbiz Could this be reviewed and merged, please? |
|
Closing in favor of #245 245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using https://github.com/ankane/strong_migrations gem, it also overrides the SchemaDumper.
Reference:
https://github.com/Laykou/strong_migrations/blob/master/lib/strong_migrations/schema_dumper.rb
strong_migrations in combination with this gem created following issue:
Module#prependis recommended approach to be used here instead of monkey patching as advised here ankane/strong_migrations#270 (comment)