Version 2 kick off with docker support #168
Conversation
|
@rbmy FYI |
|
will this be merged or replace what's in the master branch? I believe this is the feature/docker-v2 branch only. |
There was a problem hiding this comment.
For Dockerfile:
I see that you commented out the lines for make migrations and migrate. The purpose of these is to update the database upon start up if the model (think schema) is updated. I've verified that if it runs and there are no changes then no action is performed.
For ancfinder/urls.py:
path('well-known/', include('lets encrypt.urls')) can be removed. This was an attempt at using Django's admin console for generating a challenge.
|
I'd like to get this merged into master quickly. Those database steps need to be run outside of the build process since they require the DB to be there. I'll remove the django lets encrypt |
mkalish
force-pushed
the
feature/docker-v2
branch
6 times, most recently
from
b2f59da
to
1c1f092
Compare
mkalish
force-pushed
the
feature/docker-v2
branch
from
1c1f092
to
785c640
Compare
mkalish
force-pushed
the
feature/docker-v2
branch
from
785c640
to
1a420bb
Compare
mkalish
force-pushed
the
feature/docker-v2
branch
from
1a420bb
to
3593530
Compare
mkalish
force-pushed
the
master
branch
6 times, most recently
from
9690fec
to
cc90728
Compare
No description provided.