feat: poll for all job completions in wait mode #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Looks good! Will include this change in the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the
quantityparameter is not respected when creating an image withwait=True.The
_poll_for_job_completionwill return job results as soon as there's at least one job completed (blobUrlavailable). Ifquantitywas more than1, it will not poll for all the jobs to finish. In this case, other jobs may still not be available yet.Changes
This PR fixes
_poll_for_job_completionso it polls for all jobs and only return if all job results are available or times out.Note
If any job in the job batch fails (neither available nor scheduled), it'll wait until it times out.