Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed the kubernetes cluster config #34

Merged
merged 4 commits into from
Apr 7, 2020
Merged

changed the kubernetes cluster config #34

merged 4 commits into from
Apr 7, 2020

Conversation

alejandrojnm
Copy link
Member

  • Modify the kubernetes cluster config to add pagination
  • Changed the old kubernetesCluster in favor of kubernetesItem

@alejandrojnm
(hotfix) changed the kubernetes cluster config
35d8cd2 
- Modify the kubernetes cluster config to add pagination
- Changed the old kubernetesCluster in favor of kubernetesItem

BREAKING CHANGE: No

Signed-off-by: Alejandro JNM <alejandrojnm@gmail.com>
@alejandrojnm
(hotfix) fixed comment
8fdbde0 
- fix comment inside kubernetes.go

BREAKING CHANGE: No

Signed-off-by: Alejandro JNM <alejandrojnm@gmail.com>
@alejandrojnm
(hotfix) fixed code style
4cda645 
- fix code style in kubernetes.go

BREAKING CHANGE: No

Signed-off-by: Alejandro JNM <alejandrojnm@gmail.com>
andyjeffries
andyjeffries reviewed Apr 7, 2020
View reviewed changes
kubernetes.go Outdated Show resolved Hide resolved
andyjeffries
andyjeffries reviewed Apr 7, 2020
View reviewed changes
kubernetes.go Outdated Show resolved Hide resolved
andyjeffries
andyjeffries reviewed Apr 7, 2020
View reviewed changes
kubernetes.go Outdated Show resolved Hide resolved
andyjeffries
andyjeffries reviewed Apr 7, 2020
View reviewed changes
kubernetes.go Outdated Show resolved Hide resolved
andyjeffries
andyjeffries reviewed Apr 7, 2020
View reviewed changes
kubernetes.go Outdated Show resolved Hide resolved
andyjeffries
andyjeffries reviewed Apr 7, 2020
View reviewed changes
kubernetes.go Outdated Show resolved Hide resolved
@alejandrojnm
refactor(kubernetes): modify the struct for kubernets object
c343ea7 
- modify the struct for kubernets object
- fixed error in code

BREAKING CHANGE: No

Signed-off-by: Alejandro JNM <alejandrojnm@gmail.com>
@andyjeffries andyjeffries merged commit 6ce671a into master Apr 7, 2020
@andyjeffries andyjeffries deleted the hotfix/kubernetes_cluster branch April 7, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyjeffries andyjeffries andyjeffries left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alejandrojnm @andyjeffries