Issue-231 Fixed no Instances found

[kitarp29]

• civo <resourcetype> ls should show output even if empty #231
  Hi @kaihoffman this is an easy and quick fix for the issue.
  I wanted to break the loop in the length of the array is zero.
  But I am concerned about the common.OutputFormat condition .
  Please review and let me know of the changes.
  Signed-off-by: kitarp29 kitarpsinghrajpoot@gmail.com

[alejandrojnm]

Hi @kitarp29 thanks for the PR, but more than this you can return a message before the loop like in the line

cli/cmd/instance/instance_list.go

Line 60 in cc8f88e

in that way we can avoid the execution of the rest of the code, it can be something like this

if len(instance) == 0 {
	utility.Info("We don't find any instance in the region %s", client.Region)
	os.Exit(1)
}

[kitarp29]

Yes @alejandrojnm as I mentioned in my first message I knew that the rest of the code did not make sense to execute if len(instance)==0.
So should I commit the changes you mentioned or just add a break at the end of my code snippet?
cc: @kaihoffman

[RealHarshThakur]

@kitarp29 thanks for the PR :)

[alejandrojnm]

We need to keep a standard in all the code, we can use println in some place and in others use utility.Info

[RealHarshThakur]

Good point @alejandrojnm . We should move to a well-maintained logging package at some point like @kitarp29 pointed out in this issue. #233

[RealHarshThakur]

@alejandrojnm Do we want to hold this off until we resolve the logging issue?