Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update cluster firewall #445

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

haardikdharma10
Copy link
Contributor

Description

This PR-

  • Adds a new command to allow updating firewall for a kubernetes cluster.
  • Bumps civogo module to the latest version.

Fixes

#444

var kubernetesUpdateCmd = &cobra.Command{
Use: "update",
Aliases: []string{"edit"},
Short: "Update a Kubernetes cluster",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to be more specific here "Update the configuration of your Civo Kubernetes cluster" or something like that --> This makes it more specific to the user that they are updating just the configuration platform side, if that makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@fernando-villalba fernando-villalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haardikdharma10 haardikdharma10 merged commit 8a5fa36 into master Jul 17, 2024
1 check passed
@haardikdharma10 haardikdharma10 deleted the add-fw-update branch July 17, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants