Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject remote api calls when remote isn't connected #32

Closed
cjam opened this issue Feb 28, 2020 · 0 comments
Closed

Reject remote api calls when remote isn't connected #32

cjam opened this issue Feb 28, 2020 · 0 comments
Assignees
@cjam
Labels
bug Something isn't working

Comments

@cjam
Copy link
Owner

cjam commented Feb 28, 2020

All of the remote api calls currently check to see if the remote is nil and if so they ditch out. This is a bug as the promise is never rejected or resolved.
@cjam cjam added the bug Something isn't working label Feb 28, 2020
@cjam cjam self-assigned this Feb 28, 2020
cjam added a commit that referenced this issue Mar 22, 2020
@cjam
#32 Wrap api calls in checks to reject on unready
1462c72
@cjam cjam mentioned this issue Mar 22, 2020
Merged
cjam added a commit that referenced this issue Mar 22, 2020
@cjam
Fix/safer api use (#36)
e9baef6 
* Small updates to example

* #35 handle nils in player state

* #32 Wrap api calls in checks to reject on unready

* Bumping version and adding changelogs
@cjam cjam closed this as completed Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjam cjam

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjam