Fix channel selection for AU915-928 US902-928 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting the channel to transmit, the library is omitting that not all channels can use all SF. That is the case for AU915-928 and US902-928. I noticed that TTN was forcing a SF7 (with ADR) but something my device was transmitting at SF8BW500 (channel 65). Immediately after that TX, TTN was sending a new ADR command to use SF7 again.
After debugging the library, I've found out that the
selectChannelfunction was selecting any available channel, regardless if the desired data rate was obtainable or not (the functionrequiredRatewas approximating the closest data rate, which I'm not sure if it's valid, at least TTN didn't like it). I've added a new parameter (desired_rate) to the functionisAvailableto check if the required channel index is compatible with the desired SF. Probably theselectChannelfunction needs a refactoring. But for now I think this works fine.