Skip to content

Commit

Permalink
build: only generate specified build type files
Browse files Browse the repository at this point in the history
Release and Debug build configurations can not be shared, only
generate specified configuration in `configure`.

PR-URL: nodejs#53511
Fixes: nodejs#53446
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
legendecas authored and pull[bot] committed Nov 6, 2024
1 parent 1901779 commit d70258e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -2253,7 +2253,7 @@ def make_bin_override():
gyp_args += ['-Dpython=' + python]

if options.use_ninja:
gyp_args += ['-f', 'ninja-' + flavor]
gyp_args += ['-f', 'ninja-' + flavor, '-G', 'config=' + config['BUILDTYPE']]
elif flavor == 'win' and sys.platform != 'msys':
gyp_args += ['-f', 'msvs', '-G', 'msvs_version=auto']
else:
Expand Down

0 comments on commit d70258e

Please sign in to comment.