fix: Add upper python version restriction to isort and darglint #1152
Conversation
eyllanesc
changed the title
eyllanesc
changed the title
eyllanesc
changed the title
| @@ -28,14 +28,15 @@ click = ">=8.0.1" | |||
| Pygments = ">=2.10.0" | |||
| black = ">=21.10b0" | |||
| coverage = {extras = ["toml"], version = ">=6.2"} | |||
| darglint = ">=1.8.1" | |||
| darglint = {version = ">=1.8.1", python = "<4"} | |||
| urllib3 = {version = ">=1.26.8", python = "<4"} | |||
There was a problem hiding this comment.
@paw-lu When I tested I saw that if you don't set the version of urllib3 then a version of urllib3 was downloaded that had a bug, and the library that urllib3 used was darglint so I put it there.
There was a problem hiding this comment.
urllib3 should not be a direct dependency. You're right that Poetry will downgrade it to a version without a Python cap. urllib3 requires Python < 4, and it's an indirect dependency via safety and sphinx. We could make this work by adding the environment marker to safety and sphinx as well. However, I'm now considering whether we should add the Python cap back. I'll open an issue shortly so we can discuss the pros and cons of this move.
|
Superceded by cjolowicz/cookiecutter-hypermodern-python-instance#832 |
Fixes #1148