Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for dead links in documentation #699

Merged
merged 9 commits into from
Apr 15, 2021
Merged

Conversation

oncleben31
Copy link
Contributor

The cookiecutter documentation is very complete and is full of external links.

I suggest to add a nox session and a GitHub workflow to check if there is no dead links in the documentation.

According to your feedback we could add it in the template too.

To workarround an error to an interanl link referenced directly with its
html file name.
@oncleben31
Copy link
Contributor Author

And you have one dead link to fix ;-)

Base automatically changed from master to main February 18, 2021 19:02
Copy link
Owner

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is very useful! 💚 And sorry it took ages for me to get around to reviewing this...

This caught quite a few broken links, which I fixed by pushing to your branch. I also added the --keep-going option so we get to see all the broken links in one go.

I'll merge this once the CI passes.

@cjolowicz cjolowicz merged commit a3adca4 into cjolowicz:main Apr 15, 2021
@cjolowicz cjolowicz added this to the 2021.4.15 milestone Apr 15, 2021
@cjolowicz cjolowicz added cookiecutter Changes outside of the template directory testing Adding missing tests or correcting existing tests labels Apr 15, 2021
@cjolowicz cjolowicz mentioned this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cookiecutter Changes outside of the template directory testing Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants