Fix pagination style (CSS) #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2399
Proposed fixes:
In issue #2399 it is shown that the pagination laps out of the main div. Removing the
.module .paginationstyle fixed that (specifically theheight).I also noticed that the pagination is pretty broken overall. Take a look at the screenshots from the primer below:
Pagination before (from primer)
#### Pagination after (from primer)
#### Tags page afterMost of this was achieved by deleting css rules that to be honest did not really make sense to me.
Do you think there might be other places where this was a wanted behavior of the pagination?
Features: