Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception email parameters #4831

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Fix exception email parameters #4831

merged 1 commit into from
Jun 6, 2019

Conversation

davidread
Copy link
Contributor

Fixes #4830

Proposed fixes:

Fixes SMTPHandler "mailhost" parameter format. This is needed when you configure exception emails (and don't specify the SMTP port number).

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@davidread davidread requested a review from Zharktas June 5, 2019 13:50
Zharktas
Zharktas approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@Zharktas Zharktas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally should have made those tests when you asked them. 😂

@davidread
Copy link
Contributor Author

Cheers for reviewing this. I'll let one of the others merge.

No worries about a test - this config only happens if not running under test!

@wardi wardi merged commit 12644fc into master Jun 6, 2019
@davidread davidread deleted the 4830-fix-exception-emails branch June 24, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zharktas Zharktas Zharktas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError when you configure exception emails
3 participants
@davidread @Zharktas @wardi