Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 when selecting the same date in the changes view #7191

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

amercader
Copy link
Member

In the /dataset/<id>/changes_multiple page, if the user selects the same date in both select controls a 404 is returned. The case when the second date was more recent than the first one is already handled (selecting the most recent version), we just need to account for the case when both dates are the same.

404_activities.mp4

This could probably be handled better with more clever select controls that update with the relevant options but this is a good first patch

In the /dataset/id/changes_multiple page, if the user selects the same
date in both select controls a 404 is returned. The case when the second
date was more recent than the first one is already handled (selecting
the most recent version), we just need to account for the case when both
dates are the same.
Copy link
Contributor

@kowh-ai kowh-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR on a new CKAN Master installation - works great!

@kowh-ai
Copy link
Contributor

kowh-ai commented Nov 14, 2022

@amercader - another scenario I tested was where there was just 1 update to a dataset, therefore 1 activity associated with this dataset - clicking through the "Changes" link in the Activity Stream tab also caused a 404

@kowh-ai kowh-ai merged commit addd3fb into master Nov 14, 2022
@kowh-ai kowh-ai deleted the fix-same-date-in-changes branch November 14, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants