add recipient only if there is email #510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add sysadmin to the recipient only if the sysadmin account has a non-empty email address.
This fixes the following issue:
CKAN core creates a sysadmin account using
site_id
as name,None
as email in code https://github.com/ckan/ckan/blob/master/ckan/logic/action/get.py#L2428-L2433, therefore we were sending aNone
as email address down the line and eventually the mailer will generate an error.