SQLAlchemy v2 support #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility with the new SQLAlchemy version tested against this PR.
I noticed a problem caused by the
unicode_safevalidator recently added to the extras-value. It's not related to the current PR, but to make all tests green you have to manually removeunicode_safefrom here. I'll investigate and report this problem separately.Changes are mostly straightforward if you wonder why
target.source = target.job.sourceremoved: this code is executed inside an event listener that does not allow modifying relationship properties(harvest_object.source). Instead, you can only modify real columns that reference the related object(harvest_object.harvest_source_id). On the next line, right after the one I removed, exactly this thing happens, so the removed line did nothing anyway.