Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about scopes on assignment #37

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Add note about scopes on assignment #37

merged 1 commit into from
Nov 9, 2024

Conversation

ckaznocha
Copy link
Owner

closes #33

@ckaznocha ckaznocha self-assigned this Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • testdata/main.go.golden: Language not supported
Comments skipped due to low confidence (1)

testdata/main.go:341

  • [nitpick] The comment is too verbose and could be simplified for clarity. Suggestion: 'for loop can be changed to use an integer range (Go 1.22+). Ensure side effects are intentional.'
for i = 0; i < 10; i++ { // want `for loop can be changed to use an integer range \(Go 1\.22\+\)\nBecause the key is not part of the loop's scope, take care to consider side effects.`
@ckaznocha ckaznocha merged commit e286abb into main Nov 9, 2024
8 checks passed
@ckaznocha ckaznocha deleted the clif/external-key branch November 10, 2024 01:19
@ckaznocha ckaznocha mentioned this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable the linter if loop variable is used after the loop
1 participant