Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency enquirer to v2.4.1 #394

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 26, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
enquirer 2.3.6 -> 2.4.1 age adoption passing confidence

Release Notes

enquirer/enquirer (enquirer)

v2.4.1

Compare Source

v2.4.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@Daryl-L
Copy link
Contributor

Daryl-L commented Jul 27, 2023

image

I could not find any differences here...

@Keith-CY
Copy link
Member

Keith-CY commented Jul 27, 2023

image I could not find any differences here...

A CR at the end in received string

@Keith-CY
Copy link
Member

image I could not find any differences here...

A CR at the end in received string

It's a bit weird, the error was resolved by fixing the node version from v18.17.x to v18.16.x, e.g. https://github.com/ckb-js/kuai/actions/runs/5680015042/job/15393278313

But I've tried

$ const { execSync } = require('child_process')
$ execSync('echo "{ variadicParam: [ 1, 2 ] }"').toString()

with Node.js v18.6.0, v18.6.1, v18.17.0 and they all returned with \n at the end

# '{ variadicParam: [ 1, 2 ] }\n'

I haven't verified if expect trims the string.

Keith-CY added a commit that referenced this pull request Jul 27, 2023
```bash
$ const { execSync } = require('child_process')
$ execSync('echo "{ variadicParam: [ 1, 2 ] }"').toString()
```

Ref: #394 (comment)
Keith-CY added a commit that referenced this pull request Jul 27, 2023
```bash
$ const { execSync } = require('child_process')
$ execSync('echo "{ variadicParam: [ 1, 2 ] }"').toString()
```

Ref: #394 (comment)
Keith-CY added a commit that referenced this pull request Jul 27, 2023
```bash
$ const { execSync } = require('child_process')
$ execSync('echo "{ variadicParam: [ 1, 2 ] }"').toString()
```

Ref: #394 (comment)
Keith-CY added a commit that referenced this pull request Jul 27, 2023
```bash
$ const { execSync } = require('child_process')
$ execSync('echo "{ variadicParam: [ 1, 2 ] }"').toString()
```

Ref: #394 (comment)
Keith-CY added a commit that referenced this pull request Jul 27, 2023
```bash
$ const { execSync } = require('child_process')
$ execSync('echo "{ variadicParam: [ 1, 2 ] }"').toString()
```

Ref: #394 (comment)
Keith-CY added a commit that referenced this pull request Jul 27, 2023
```bash
$ const { execSync } = require('child_process')
$ execSync('echo "{ variadicParam: [ 1, 2 ] }"').toString()
```

Ref: #394 (comment)
Keith-CY added a commit that referenced this pull request Jul 27, 2023
```bash
$ const { execSync } = require('child_process')
$ execSync('echo "{ variadicParam: [ 1, 2 ] }"').toString()
```

Ref: #394 (comment)
@renovate renovate bot force-pushed the renovate/enquirer-2.x branch from 94920cc to 7cd3206 Compare July 28, 2023 02:04
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #394 (979f4b1) into develop (98efd3e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #394   +/-   ##
========================================
  Coverage    62.39%   62.39%           
========================================
  Files           94       94           
  Lines         3101     3101           
  Branches       688      688           
========================================
  Hits          1935     1935           
  Misses        1057     1057           
  Partials       109      109           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98efd3e...979f4b1. Read the comment docs.

@renovate renovate bot force-pushed the renovate/enquirer-2.x branch 2 times, most recently from 83b0530 to 91003ad Compare July 28, 2023 02:11
@renovate renovate bot force-pushed the renovate/enquirer-2.x branch from 91003ad to d482439 Compare July 28, 2023 03:21
@Keith-CY Keith-CY enabled auto-merge July 28, 2023 03:37
@renovate renovate bot changed the title fix(deps): update dependency enquirer to v2.4.0 fix(deps): update dependency enquirer to v2.4.1 Jul 28, 2023
@renovate renovate bot force-pushed the renovate/enquirer-2.x branch from d482439 to 979f4b1 Compare July 28, 2023 14:08
@Keith-CY Keith-CY added this pull request to the merge queue Jul 29, 2023
Merged via the queue into develop with commit a869854 Jul 29, 2023
@Keith-CY Keith-CY deleted the renovate/enquirer-2.x branch July 29, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants