Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ckb-indexer)!: wait for the next n blocks #655

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

homura
Copy link
Collaborator

@homura homura commented Mar 20, 2024

Description

The implementation of waitForSync is incorrect, although it should semantically wait for the next N blocks

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Mar 20, 2024 3:47am

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.30%. Comparing base (4edfce4) to head (6564de2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #655   +/-   ##
========================================
  Coverage    84.30%   84.30%           
========================================
  Files          121      121           
  Lines        24574    24574           
  Branches      2364     2364           
========================================
  Hits         20717    20717           
  Misses        3816     3816           
  Partials        41       41           
Files Coverage Δ
packages/ckb-indexer/src/indexer.ts 41.51% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edfce4...6564de2. Read the comment docs.

@homura homura added this to the 0.23.0 milestone Mar 20, 2024
Copy link
Contributor

@PainterPuppets PainterPuppets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@homura homura modified the milestones: 0.23.0, 0.24.0 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 Code Review
Development

Successfully merging this pull request may close these issues.

2 participants