add admin.py; add serializer overrides + chat_settings #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chit_chat/migrations/0001_initial.py
Outdated
| ('user', models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='chat_room_memberships', to=settings.AUTH_USER_MODEL)), | ||
| ], | ||
| ), | ||
| migrations.AddField( |
There was a problem hiding this comment.
Only concern here is compatibility with applications already running chit-chat. Not massively important though.
What could make sense is:
- Create new m2m ,
members_tmp, with though model. - Create data migration to load new field with old field's data.
- Delete old m2m field.
- Rename new m2m
members_tmp=>members.
There was a problem hiding this comment.
pushed this up, hand tested a couple times, should worky!
chit_chat/ckc_conf.py
Outdated
Comment on lines
24
to
27
| # Override default serializers.. | ||
| if hasattr(settings, 'CKC_CHAT_SERIALIZERS'): | ||
| for name, module in settings.CKC_CHAT_SERIALIZERS.items(): | ||
| chat_settings['SERIALIZERS'][name] = module |
There was a problem hiding this comment.
I'm making sure this guy is covered in a test right now.
… signal. Add MESSAGE serializer to default settings.
… serializer from django settings with new style. Update test for new serializer config style.
…go-chit-chat into better-serializer-overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.