Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ mention of reviewers
@ckcollab
A brief description of the purpose of the changes contained in this PR.
Before:
user_1
anduser_2
connect to chat websocketuser_1
creates new chatroom with membersuser_1
anduser_2
user_1
sends message to new chatroomuser_1
never receives the repeated message from the websocket to confirm that the message was successfully sentuser_2
never receives message, because he connects to the rooms when he connects the websocketNow:
user_1
anduser_2
connect to chat websocketuser_1
creates new chatroom with membersuser_1
anduser_2
The list of chatrooms that
user_1and
user_2` are listening to is automatically refresheduser_1
sends message to new chatroomuser_1
receives reflected message back from server, confirming that his message was successfully consumed by serveruser_2
receives message from the room broadcastMisc. comments
Running into this case in Udayos. This should fix it.
Checklist