Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for color history feature #318

Merged
merged 3 commits into from
Sep 4, 2020
Merged

Add docs for color history feature #318

merged 3 commits into from
Sep 4, 2020

Conversation

Dumluregn
Copy link
Contributor

Introduced in ckeditor/ckeditor4#3784, color history feature lacks the proper documentation besides API docs. This PR add some information about using it as well as the examples.

Closes ckeditor/ckeditor4#4237.

Sorry the gif quality - that's the best what my recording software achieved. For sure it needs to be done better.

@f1ames f1ames self-requested a review September 2, 2020 12:12
@f1ames f1ames self-assigned this Sep 2, 2020
@f1ames
Copy link
Contributor

f1ames commented Sep 3, 2020

Rebased onto latest major.

@f1ames f1ames removed their request for review September 3, 2020 12:19
@f1ames
Copy link
Contributor

f1ames commented Sep 3, 2020

Overtook this PR since @Dumluregn is off.

@f1ames f1ames requested a review from godai78 September 3, 2020 12:19
@f1ames f1ames removed their assignment Sep 3, 2020
@f1ames
Copy link
Contributor

f1ames commented Sep 3, 2020

@godai78 could you review it?

Also it would make sense to redo outdated screenshots in features section. I lack HiDPI device ATM so it would be good if someone with such device can do this. @godai78 can I ask you to cover this also? If not, we will find another volunteer ;) It looks in fact to be doable (1, 2), so I will check how it looks.

@godai78
Copy link
Collaborator

godai78 commented Sep 3, 2020

I will look to it soon as I can.

@f1ames
Copy link
Contributor

f1ames commented Sep 3, 2020

It looks in fact to be doable (1, 2), so I will check how it looks.

Doable, after forcing CKEDIOTR.env.hidpi = true in CKEditor so HiDPI icons are used too. Anyway, after I've done screenshots and cut them nicely, I realized that editor language was set to pl (due to browser settings) so I have to redo them in English once again 😭 🤦

@godai78 godai78 merged commit a529b36 into major Sep 4, 2020
@godai78 godai78 deleted the t/4237 branch September 4, 2020 11:46
godai78 added a commit that referenced this pull request Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants