Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error definition (invalid-callback) #344

Closed
wants to merge 3 commits into from
Closed

Conversation

sculpt0r
Copy link
Contributor

@sculpt0r sculpt0r commented Jan 7, 2021

According to ckeditor/ckeditor4#4461:

Added invalid-callback error documentation.
It could be thrown whenever a callback function is expected, but something else was provided.

@Dumluregn
Copy link
Contributor

AFAICS this error will be first used in ckeditor/ckeditor4#4463, so target branch here should be major (if we release this docs change now, the error will not be present yet in core/creators/themedui.js).

Also it should probably me reviewed and merged after the base PR is ready, so I'm marking it as blocked by ckeditor/ckeditor4#4463.

@Dumluregn Dumluregn added the status:blocked An issue which development is blocked by another issue (internal or external one). label Jan 12, 2021
@Dumluregn
Copy link
Contributor

Due to the change of ckeditor/ckeditor4#4463 implementation, this PR is no longer valid.

@Dumluregn Dumluregn closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:blocked An issue which development is blocked by another issue (internal or external one).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants