Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget's upcast methods are not called in widget definiton's context #1097

Closed
Comandeer opened this issue Oct 27, 2017 · 0 comments · Fixed by #1098
Closed

Widget's upcast methods are not called in widget definiton's context #1097

Comandeer opened this issue Oct 27, 2017 · 0 comments · Fixed by #1098
Labels
changelog:api A changelog entry should be put in the API section of the changelog. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone
4.8.0

Comments

@Comandeer
Copy link
Member

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open console.
  2. Go to http://jsfiddle.net/6mk8e7sa/

Expected result

this points to widget definition

Actual result

this points to totally custom object, which does not contain reference to widget's definition.
@Comandeer Comandeer added plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Oct 27, 2017
@Comandeer Comandeer mentioned this issue Oct 27, 2017
Merged
2 tasks
@mlewand mlewand added the changelog:api A changelog entry should be put in the API section of the changelog. label Oct 30, 2017
@mlewand mlewand added this to the 4.8.0 milestone Oct 30, 2017
@f1ames f1ames added the target:major Any docs related issue that should be merged into a major branch. label Nov 2, 2017
f1ames added a commit that referenced this issue Nov 2, 2017
@f1ames
Merge pull request #1098 from ckeditor/t/1097
c74f3a1 
Fix scope of widget's upcast methods (#1097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog:api A changelog entry should be put in the API section of the changelog. plugin:widget The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

#1097 Fix scope of widget's upcast methods ckeditor/ckeditor4
3 participants
@f1ames @Comandeer @mlewand