Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition while uploading images to CKFinder using uploadimage plugin #1213

Closed
mlewand opened this issue Nov 23, 2017 · 2 comments · Fixed by #1216
Closed

Race condition while uploading images to CKFinder using uploadimage plugin #1213

mlewand opened this issue Nov 23, 2017 · 2 comments · Fixed by #1216
Labels
plugin:uploadimage The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone
4.8.0

Comments

@mlewand
Copy link
Contributor

mlewand commented Nov 23, 2017 •
edited
Loading

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open a new tab - https://codepen.io/mlewand/pen/RjyoPR.
  2. Select all four images rendered in HTML preview.
  3. Copy with ctrl/cmd+c.
  4. Open https://sdk.ckeditor.com/samples/fileupload.html#uploading-dropped-and-pasted-images.
  5. Focus and clear contents of editor under "Uploading Dropped and Pasted Images".
  6. Paste using ctrl/cmd+v.

Expected result

All four images are upload, each image is different.

Actual result

Randomly some images will duplicate/mangle. If you did not reproduced try again, as it's a basically a race condition.

Other details

  • Browser: All
  • OS: Windows 10, Mac
  • CKEditor version: 4.7.3
@Comandeer Comandeer added plugin:uploadimage The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Nov 23, 2017
@Comandeer
Copy link
Member

It seems that issue is less likely to happen with open console with "disable cache" option checked.

@mlewand
Copy link
Contributor Author

mlewand commented Nov 23, 2017

It seems that issue is less likely to happen with open console with "disable cache" option checked.

That has to do with a lower performance of HTTP requests. I had significantly "better" results with IE11 too. 🙂

mlewand added a commit that referenced this issue Nov 23, 2017
@mlewand
Added a workaround for #1213 so that the backend is not spammed with …
054cb9b 
…files having the same name.
@mlewand mlewand mentioned this issue Nov 23, 2017
Merged
2 tasks
Comandeer pushed a commit that referenced this issue Nov 23, 2017
@mlewand @Comandeer
Added a workaround for #1213 so that the backend is not spammed with …
24eeb27 
…files having the same name.
@mlewand mlewand added this to the 4.8.0 milestone Nov 23, 2017
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:uploadimage The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

Fix for race condition while uploading multiple files with uploadimage plugin ckeditor/ckeditor4
2 participants
@Comandeer @mlewand