Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget nested editable triggers blur event on focus in Firefox #2470

Closed
mflorea opened this issue Oct 10, 2018 · 2 comments
Closed

Widget nested editable triggers blur event on focus in Firefox #2470

mflorea opened this issue Oct 10, 2018 · 2 comments
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. plugin:copyformatting The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@mflorea
Copy link
Contributor

mflorea commented Oct 10, 2018

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open https://jsfiddle.net/7t4wvg06/6/ using Firefox
  2. Open the JavaScript console (Developer Tools)
  3. Click over "foo" to focus the widget (inside the CKEditor's editing area)
  4. Type something in the widget
  5. Click below "foo" to blur the widget (i.e. outside of the widget)

Expected result

Step 3 should log

editable focus

and step 5 should log

editable blur

Actual result

Step 3 logs

editable focus
editable blur

and step 5 doesn't log anything.

Other details

  • Browser: Firefox 61.0.1
  • OS: Ubuntu 17.10
  • CKEditor version: both 4.10.1 and 4.10.0
  • Installed CKEditor plugins: copyformatting

It doesn't reproduce on Chrome or if you remove the copyformatting plugin.

My investigation shows that this is a regression caused by 3a9f058 which was committed in CKEditor 4.10.0 . The change for Firefox is that

editorFocus: false,

has become

editorFocus: true,

so the applyFormatting command requires the editor to be focused but in my case I don't call this command explicitly so I don't understand how it affects the widget.

@engineering-this engineering-this self-assigned this Oct 15, 2018
@engineering-this engineering-this added browser:firefox The issue can only be reproduced in the Firefox browser. plugin:widget The plugin which probably causes the issue. type:bug A bug. status:confirmed An issue confirmed by the development team. regression This issue is a regression. labels Oct 15, 2018
@engineering-this
Copy link
Contributor

@mflorea thank you for your report. I can confirm this bug.

@engineering-this engineering-this removed their assignment Oct 15, 2018
@Comandeer Comandeer added plugin:copyformatting The plugin which probably causes the issue. and removed plugin:widget The plugin which probably causes the issue. labels Feb 14, 2019
Comandeer added a commit that referenced this issue Feb 14, 2019
Comandeer added a commit that referenced this issue Feb 14, 2019
msamsel pushed a commit that referenced this issue Feb 19, 2019
Comandeer added a commit that referenced this issue Feb 19, 2019
@Comandeer
Copy link
Member

The issue was fixed by #2792. The fix will be released in 4.11.3.

@Comandeer Comandeer added this to the 4.11.3 milestone Feb 19, 2019
ad1992 pushed a commit to interviewstreet/ckeditor-dev that referenced this issue May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. plugin:copyformatting The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants