Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles mapping for deprecated / system colors #3112

Open
jacekbogdanski opened this issue May 17, 2019 · 0 comments
Open

Styles mapping for deprecated / system colors #3112

jacekbogdanski opened this issue May 17, 2019 · 0 comments
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@jacekbogdanski
Copy link
Member

Type of report

Feature request

Provide description of the new feature

Currently, system colors are not correctly recognized by CKEDITOR.tools.style.parse functions (#2923). As the colors may introduce some issues with different color among the systems where we expect the concrete one, it makes sense to create some public mapping which will convert styles to the expected. It should also allow to disable or change a mapping by the developer if needed.

Some poor mapping has been already introduced for Border style type (#2924) where windowtext is mapped into black color. We should extract this logic into separate namespace inside CKEDITOR.tools.style.

Note that this mapping is not limited to colors, we may need some other style mappings in the future, so the general method shouldn't limit itself to the concrete style property.

@jacekbogdanski jacekbogdanski added type:feature A feature request. status:confirmed An issue confirmed by the development team. core The issue is caused by the editor core code. labels May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

No branches or pull requests

1 participant